Skip to content

Commit

Permalink
fix: show problem title instead of displayId
Browse files Browse the repository at this point in the history
  • Loading branch information
ReuDa committed Dec 1, 2023
1 parent be9e96e commit d0bf86a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion e2e/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func testCheckProblem(t *testing.T, m *e2e.Minikube, e *e2e.Extension) {
for _, metric := range metrics {
problemId := "-703143834675302702_1701158040000V2"
assert.Equal(t, problemId, metric.Metric["dynatrace.problem.id"])
assert.Equal(t, "P-2311100", metric.Metric["dynatrace.problem.displayId"])
assert.Equal(t, "Container restarts", metric.Metric["dynatrace.problem.title"])
assert.Equal(t, fmt.Sprintf("http://mock/ui/apps/dynatrace.classic.problems/#problems/problemdetails;pid=%s", problemId), metric.Metric["url"])
}
}
14 changes: 7 additions & 7 deletions extproblems/problem_check.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func (m *ProblemCheckAction) Describe() action_kit_api.ActionDescription {
From: "dynatrace.problem.id",
},
Label: action_kit_api.StateOverTimeWidgetLabelConfig{
From: "dynatrace.problem.displayId",
From: "dynatrace.problem.title",
},
State: action_kit_api.StateOverTimeWidgetStateConfig{
From: "state",
Expand Down Expand Up @@ -245,19 +245,19 @@ func ProblemCheckStatus(ctx context.Context, state *ProblemCheckState, api Probl
}

func toMetric(problem types.Problem, now time.Time) action_kit_api.Metric {
tooltip := problem.Title
tooltip := problem.DisplayId
for _, entity := range problem.AffectedEntities {
tooltip += fmt.Sprintf("\n- %s", entity.Name)
}

return action_kit_api.Metric{
Name: extutil.Ptr("dynatrace_problems"),
Metric: map[string]string{
"dynatrace.problem.id": problem.ProblemId,
"dynatrace.problem.displayId": problem.DisplayId,
"state": "danger",
"tooltip": tooltip,
"url": fmt.Sprintf("%s/apps/dynatrace.classic.problems/#problems/problemdetails;pid=%s", config.Config.UiBaseUrl, problem.ProblemId),
"dynatrace.problem.id": problem.ProblemId,
"dynatrace.problem.title": problem.Title,
"state": "danger",
"tooltip": tooltip,
"url": fmt.Sprintf("%s/apps/dynatrace.classic.problems/#problems/problemdetails;pid=%s", config.Config.UiBaseUrl, problem.ProblemId),
},
Timestamp: now,
Value: 0,
Expand Down

0 comments on commit d0bf86a

Please sign in to comment.