Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean Conditional is not working #33

Closed
pYr0x opened this issue Feb 5, 2017 · 5 comments
Closed

Boolean Conditional is not working #33

pYr0x opened this issue Feb 5, 2017 · 5 comments
Assignees
Labels

Comments

@pYr0x
Copy link

pYr0x commented Feb 5, 2017

a import like
require('~/modules/notice-box#?triwala-vk/modules/notice-box-exists');
where triwala-vk/modules/notice-box-exists is the module that exports a boolean does not work.

a error is thrown Condition modules cannot contain . or / in the name
https://github.com/stealjs/steal-conditional/blob/master/conditional.js#L58

@m-mujica do you know why . and / is forbidden?

@matthewp
Copy link
Member

matthewp commented Feb 7, 2017

I think / is the problem here, it shouldn't be forbidden should it?

@m-mujica
Copy link
Contributor

m-mujica commented Feb 7, 2017

@matthewp @pYr0x the restriction on using / was inherited from the original implementation. I can't remember why it was done that way..... I'll try to remove that and see how it goes.

@pYr0x
Copy link
Author

pYr0x commented Feb 18, 2017

@m-mujica and news about this issue?

@m-mujica
Copy link
Contributor

@pYr0x I plan to work on this in my spare time or after I'm done with the dev bundle stuff....

@m-mujica
Copy link
Contributor

m-mujica commented Mar 8, 2017

@pYr0x just released v0.3.3. Please, give it a try when you have a chance and let me know how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants