-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error with string substitution on stache files #38
Comments
Also, @phillipskevin just discovered this only happens when live-reload is running. |
We have at least two issues here
|
Hm, I don't think we can do that. Look at this commit: stealjs/steal-tools@fb5af1c . How does the |
Right here steal-conditional/conditional.js Lines 249 to 253 in 984a3f5
steal-conditional looks at the env to avoid evaluating the condition modules during the build. It does the glob-stuff to detect the variations and push them to |
@matthewp I'm having troubles to figure out how to fix the steal-conditional issue The problem: detecting substitution variationsGiven a condition like
That algorithm brakes easily with identifiers like: A possible solution
I don't like there are so many moving pieces here; what do you think? |
Why would the first step result in |
Currently we only remove the condition,
Same as 1) we'll match a bunch of extra files removing everything after the condition. |
Ok makes sense. In that case I think your placeholder idea makes sense. |
a) modules using plugins, e.g: "#{foo}.css!" b) substitution of folder names, e.g: "/foo/#{platform}/index.js" Closes #38
a) modules using plugins, e.g: "#{foo}.css!" b) substitution of folder names, e.g: "/foo/#{platform}/index.js" Closes #38
a) modules using plugins, e.g: "#{foo}.css!" b) substitution of folder names, e.g: "/foo/#{platform}/index.js" Closes #38
a) modules using plugins, e.g: "#{foo}.css!" b) substitution of folder names, e.g: "/foo/#{platform}/index.js" Closes #38
1. Substitution in modules with plugins 2. Substitution of folder names Part of stealjs/steal-conditional/issues/38
a) modules using plugins, e.g: "#{foo}.css!" b) substitution of folder names, e.g: "/foo/#{platform}/index.js" Closes #38
I created an example app where the bug showed up: https://github.com/m-mujica/steal-conditional-stache In order to close this issue, we need to:
|
I am getting an error in the terminal (not in the browser) when using string substitution on stache files with done-serve.
There is no
steal-stache/
folder within thesteal-stache/
folder in mynode_modules
.I am importing the view for a component using:
import view from './#{haulhound-frontend/platform}.stache!';
Where
haulhound-frontend/platform
resolves to eitherdesktop
ormobile
Note that it actually works and loads the correct stache file and I get no error in the browser.
The text was updated successfully, but these errors were encountered: