Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deeply extending typed objects can cause infinite recursion #220

Closed
matthewp opened this issue Jan 18, 2017 · 0 comments · Fixed by #221
Closed

Deeply extending typed objects can cause infinite recursion #220

matthewp opened this issue Jan 18, 2017 · 0 comments · Fixed by #221

Comments

@matthewp
Copy link
Member

No description provided.

matthewp added a commit that referenced this issue Jan 18, 2017
@matthewp
Only extend plain objects.
c6d7a86 
Trying to extend typed objects cause infinite recursion easily when
deeply extending. The fix is to check if the object's __proto__ is
Object.prototype.

Fixes #220
@matthewp matthewp mentioned this issue Jan 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only extend plain objects. stealjs/steal-npm
1 participant
@matthewp