Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build not copying "events" from node_modules #1085

Closed
leoj3n opened this issue Oct 26, 2018 · 2 comments
Closed

Build not copying "events" from node_modules #1085

leoj3n opened this issue Oct 26, 2018 · 2 comments
Labels

Comments

@leoj3n
Copy link

leoj3n commented Oct 26, 2018

It would appear the events package is missing from the bundle. Here is npm ls events:

bitcentivez-client@0.0.1 /Users/leoj/src/bitcentivez/client
├─┬ @feathersjs/feathers@3.2.3
│ └── events@3.0.0
├─┬ can@5.15.1
│ └─┬ can-connect-feathers@5.0.0
│   └─┬ feathers-authentication-popups@0.1.2
│     └── events@1.1.1
├─┬ steal@2.1.6
│ └── events@1.1.1
└─┬ testee@0.8.1
  └─┬ feathers@2.2.4
    └── events@1.1.1

The error manifests like this within the frontend app:

image

If I update my build npm run-script to manually copy the events package from node_modules, the frontend app loads without errors because it can now find the file it was looking for:

Original build script:

    "build": "rm -rf ./prod && mkdir ./prod && node build && mv ./dist ./prod && cp ./package.json ./favicon.ico ./prod",

Updated build script:

    "build": "rm -rf ./prod && mkdir ./prod && node build && cp -r ./node_modules/events ./dist/node_modules && mv ./dist ./prod && cp ./package.json ./favicon.ico ./prod",

image

There are no other missing scripts causing errors like this, so I wonder if it's something specifically unique to the events package (perhaps its package.json is not handled properly).

@matthewp matthewp added the bug label Oct 26, 2018
@chasenlehara
Copy link
Contributor

I wonder if this is related to stealjs/steal#1490

@leoj3n Could you try the latest StealJS and check if this is still an issue please?

@leoj3n
Copy link
Author

leoj3n commented Jan 11, 2019

@chasenlehara Thanks, this does seem to no longer be an issue. Will reopen if anything changes.

@leoj3n leoj3n closed this as completed Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants