substring different on windows #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewp
reviewed
Jul 23, 2018
| @@ -17,6 +18,9 @@ function treeshake(data) { | |||
| let getNode = id => data.graph[id]; | |||
| let mains = uniq(data.mains.concat(data.loader.bundle)); | |||
| let cwd = process.cwd().substr(1); | |||
| if (os.type().toLowerCase() === "windows_nt"){ | |||
There was a problem hiding this comment.
Is this the best way to check if it's windows? In the past I've used process.platform === 'win32'.
There was a problem hiding this comment.
hmm i dont know. docs said Windows_NT https://nodejs.org/api/os.html#os_os_type
stackoverflow said process.platform https://stackoverflow.com/questions/8683895/how-do-i-determine-the-current-operating-system-with-node-js
There was a problem hiding this comment.
Ok, I'd think either will work then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check OS and substring different on windows
close #1046