Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last step is misreported as failure step #5

Open
max-sixty opened this issue Apr 23, 2018 · 2 comments
Open

Last step is misreported as failure step #5

max-sixty opened this issue Apr 23, 2018 · 2 comments

Comments

@max-sixty
Copy link
Contributor

If there are multiple steps running when a failure occurs, the latest task to start is reported as the failure reason, rather than the task with status=FAILURE

image

In the report from cloud container builds describe, isort has a (very slightly!) later start time:

  id: run-tests
  status: FAILURE
  timing:
    endTime: '2018-04-22T18:51:47.129276336Z'
    startTime: '2018-04-22T18:41:13.672572721Z'
[...]
  id: isort
  status: SUCCESS
  timing:
    endTime: '2018-04-22T18:41:28.186709447Z'
    startTime: '2018-04-22T18:41:13.672967786Z'
@stealthybox
Copy link
Owner

Thanks for reporting this @maxim-lian 👋
I think the status field is new, so we can probably rewrite the filter to use that:

const lastStep = steps.filter( s => s.timing && s.timing.startTime ).pop()
const failureDescription = (ghStatus=='failure' || ghStatus=='error')
? ' · ' + (lastStep ? `${lastStep.id} `:'') + status.toLowerCase()
: ''

@stealthybox
Copy link
Owner

I was able to grab a failing build that demonstrates this issue.
I've started writing the necessary patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants