Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break library into multiple files #2

Closed
apike opened this issue Dec 23, 2016 · 2 comments
Closed

Break library into multiple files #2

apike opened this issue Dec 23, 2016 · 2 comments
Assignees

Comments

@apike
Copy link
Member

apike commented Dec 23, 2016

Currently Bluejay is all one file - we should split it, to the degree it makes sense, by class and/or what is appropriate to get the files to roughly 50-250 lines each.

@sakuraehikaru
Copy link
Member

@apike, @nbrooke the source is now broken up into different logical files. Totally open to suggestion and changes.

A few notes on some of the reasonings behind renaming certain things:

Generic class names like “Sendable” and “Receivable” are all prefixed with “Bluejay” to make codebases that use Bluejay clearer. Otherwise if there are other libraries or context that share similar terminologies, the code can be a bit confusing to understand and slower to read.

Other generic class names such as “ServiceIdentifier” or “DataPadding” are not prefixed with “Bluejay” because they are a bit more specific already, and by trading off a bit of consistency in naming we can prevent absurdly long names in a few cases.

@apike
Copy link
Member Author

apike commented Feb 20, 2017

This is now complete. 🎉

@apike apike closed this as completed Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants