Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code refactor and fix some error #7

Merged
merged 12 commits into from
Jun 16, 2018
Merged

Conversation

vegawong
Copy link
Collaborator

fix #6

  • 拆分了大部分代码, 抽离成模块文件
  • 修复了-d命令下的一些错误
  • 优化了一些错误提示

@codecov-io
Copy link

codecov-io commented Jun 15, 2018

Codecov Report

Merging #7 into master will decrease coverage by 0.03%.
The diff coverage is 84.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   85.85%   85.81%   -0.04%     
==========================================
  Files           2        9       +7     
  Lines         509      550      +41     
  Branches       96      116      +20     
==========================================
+ Hits          437      472      +35     
- Misses         72       78       +6
Impacted Files Coverage Δ
libs/list.js 100% <100%> (ø)
index.js 100% <100%> (+15.07%) ⬆️
libs/develop.js 61.53% <61.53%> (ø)
libs/install.js 73.52% <73.52%> (ø)
libs/template.js 77.35% <77.35%> (ø)
libs/update.js 81.06% <81.06%> (ø)
libs/uninstall.js 87.5% <87.5%> (ø)
utils/kit/index.js 92.04% <90.9%> (-1.06%) ⬇️
libs/init.js 95.09% <95.09%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae4e123...03072cb. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.0%) to 79.501% when pulling 3cc1396 on vegawong:master into ae4e123 on steamerjs:master.

@coveralls
Copy link

coveralls commented Jun 15, 2018

Coverage Status

Coverage increased (+1.08%) to 79.614% when pulling 03072cb on vegawong:master into ae4e123 on steamerjs:master.

@vegawong vegawong mentioned this pull request Jun 15, 2018
   beforeInstallCopy钩子添加参数files,方便钩子内部操作
   update修复读取配置文件路径错误问题
@lcxfs1991 lcxfs1991 merged commit d35d378 into steamerjs:master Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update global版本异常
4 participants