Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add notice about ngrok acc #571

Merged
merged 1 commit into from Oct 5, 2023
Merged

docs: add notice about ngrok acc #571

merged 1 commit into from Oct 5, 2023

Conversation

maxwfreu
Copy link
Contributor

@maxwfreu maxwfreu commented Oct 4, 2023

Adds a disclaimer that an ngrok acc is required for running ship run local

@maxwfreu maxwfreu requested a review from eob October 4, 2023 18:58
eob
eob approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@eob eob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@douglas-reid douglas-reid added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit 803854f Oct 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eob eob eob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxwfreu @eob @douglas-reid