Skip to content

Commit

Permalink
#2 remove quote for env variable.
Browse files Browse the repository at this point in the history
These quotes are probably unnecessary
  • Loading branch information
sjeandeaux committed May 7, 2015
1 parent bc2a814 commit eb79d22
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name := "sbt-docker-launcher"

organization := "stebourbi"

version := "0.6"
version := "0.7-SNAPSHOT"

scalaVersion in Global := "2.10.2"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ case class ContainerInstanceDefinition(val container:Container

val commandArguments = {
val tunnels = tunneling.map(p => s"-p ${p._1}:${p._2}").mkString(" ")
val envVars = environmentVariables.map(p => s"-e ${p._1}='${p._2}'").mkString(" ")
val envVars = environmentVariables.map(p => s"-e ${p._1}=${p._2}").mkString(" ")
val linked = links.map(p => s"--link ${p._1}:${p._2}").mkString(" ")
s" $tunnels $envVars $linked -P -d --name ${container.name} ${container.repository}"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class ContainerInstanceDefinitionSpec extends FlatSpec {
it must "translate defined environment vars" in {
val cmd = new ContainerInstanceDefinition("repository","name") e ("VAR1","VAL1")

assert(" -e VAR1='VAL1' -P -d --name name repository" === cmd.commandArguments)
assert(" -e VAR1=VAL1 -P -d --name name repository" === cmd.commandArguments)

}

Expand Down
2 changes: 1 addition & 1 deletion test-project/build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ sbtPlugin := true

containers += ( ("redis","redis1") p (6379,6379) e ("VAR1","VAL1") )

containers += ( ("redis","redis2") link ("redis1","master") e ("VAR2","VAL2") )
containers += ( ("redis","redis2") link ("redis1","master") e ("VAR2","VA!L2") )

0 comments on commit eb79d22

Please sign in to comment.