Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predict zip64 filesizes #13

Merged
merged 4 commits into from
Nov 20, 2019
Merged

Predict zip64 filesizes #13

merged 4 commits into from
Nov 20, 2019

Conversation

jszobody
Copy link
Member

No description provided.

@jszobody
Copy link
Member Author

This is a WIP. Currently we are off by 96 bytes when zeroHeader is off, and 116 bytes with zeroHeader.

There were 5 failures:

1) STS\ZipStream\Tests\SizeEstimation\BigLocalFileArchiveSizeEstimationTest::testBasic
Failed asserting that 5368709278 matches expected 5368709374.

/Users/josephszobody/dev/laravel-zipstream/tests/SizeEstimation/SizeEstimationTestCase.php:56
/Users/josephszobody/dev/laravel-zipstream/tests/SizeEstimation/EmptyArchiveSizeEstimationTest.php:9

2) STS\ZipStream\Tests\SizeEstimation\BigLocalFileArchiveSizeEstimationTest::testEstimationWithArchiveComment
Failed asserting that 5368709293 matches expected 5368709389.

/Users/josephszobody/dev/laravel-zipstream/tests/SizeEstimation/SizeEstimationTestCase.php:56
/Users/josephszobody/dev/laravel-zipstream/tests/SizeEstimation/EmptyArchiveSizeEstimationTest.php:16

3) STS\ZipStream\Tests\SizeEstimation\BigLocalFileArchiveSizeEstimationTest::testEstimationWithEnableZip64 with data set #0 (true)
Failed asserting that 5368709278 matches expected 5368709374.

/Users/josephszobody/dev/laravel-zipstream/tests/SizeEstimation/SizeEstimationTestCase.php:56
/Users/josephszobody/dev/laravel-zipstream/tests/SizeEstimation/EmptyArchiveSizeEstimationTest.php:26

4) STS\ZipStream\Tests\SizeEstimation\BigLocalFileArchiveSizeEstimationTest::testEstimationWithZeroHeader with data set #0 (true)
Failed asserting that 5368709278 matches expected 5368709374.

/Users/josephszobody/dev/laravel-zipstream/tests/SizeEstimation/SizeEstimationTestCase.php:56
/Users/josephszobody/dev/laravel-zipstream/tests/SizeEstimation/EmptyArchiveSizeEstimationTest.php:36

5) STS\ZipStream\Tests\SizeEstimation\BigLocalFileArchiveSizeEstimationTest::testEstimationWithZeroHeader with data set #1 (false)
Failed asserting that 5368709234 matches expected 5368709350.

/Users/josephszobody/dev/laravel-zipstream/tests/SizeEstimation/SizeEstimationTestCase.php:56
/Users/josephszobody/dev/laravel-zipstream/tests/SizeEstimation/EmptyArchiveSizeEstimationTest.php:36

@jszobody jszobody mentioned this pull request Nov 20, 2019
@jszobody
Copy link
Member Author

FYI the 96 bytes is consistent even when there are multiple files in the zip.

@jszobody
Copy link
Member Author

This is looking good, all tests passing.

@jszobody jszobody marked this pull request as ready for review November 20, 2019 19:41
@jszobody jszobody merged commit 293161a into master Nov 20, 2019
jszobody added a commit that referenced this pull request Nov 20, 2019
@jszobody jszobody deleted the zip64-filesize-prediction branch November 21, 2019 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant