Prevent global/application options conflicting with CompletionCommand #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CompletionCommand` does not need to know about custom application-level options in user code. This filters out options that aren't in the default set provided by the base `Application` class to prevent conflicts with option names while maintaining backwards compatibility. If user-code wants to use global options in a subclass of CompletionCommand, `filterApplicationOptions` can be overridden to append any desired options to the default list. Solves the issue mentioned in #86
stecman
force-pushed
the
conflicting-options
branch
from
fa690e9
to
08a5263
Compare
|
this changes is a much better solution than my. 👍 Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompletionCommanddoes not need to know about custom application-level optionsin user code. This filters out options that aren't in the default set provided
by the base
Applicationclass to prevent conflicts with option names.If user-code wants to use global options in a subclass of CompletionCommand,
filterApplicationOptionscan be overridden to append any desired options tothe default list.
Resolves the issue from #86 in a backwards compatible way.