Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CompletionCommand.php to Add return type #94

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Update CompletionCommand.php to Add return type #94

merged 1 commit into from
Jun 23, 2023
+1 −1

Conversation

rajeshreeputra
Copy link
Contributor

Add return type, as failing with Drupal 10.1

@stecman stecman merged commit 90a1d2c into stecman:master Jun 23, 2023
@stecman
Copy link
Owner

stecman commented Jun 23, 2023

Thanks! Looks like this became an issue from symfony/console 6.3.0 👍

@stecman stecman mentioned this pull request Jun 23, 2023
Closed
@joshtrichards
Copy link

This impacts Symfony 5.x too:

https://github.com/symfony/symfony/blob/1f386a39aeb83a1b37bba008ba42061901dc5d45/src/Symfony/Component/Console/Command/LazyCommand.php#L92

Any chance this can be backported to v0.11.x as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rajeshreeputra @stecman @joshtrichards