Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gqlclient): improve test suite, allow structs for variables #4

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

steebchen
Copy link
Owner

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 4, 2019

golint

gqlclient.go:8:1: comment on exported type Client should be of the form "Client ..." (with optional leading article)
structs/structs.go:10:1: exported function Unpack should have comment or be unexported
structs/structs.go:26:1: exported function StructToMap should have comment or be unexported

@github-actions
Copy link

github-actions bot commented Jun 4, 2019

go fmt

./structs/structs_test.go

diff -u ./structs/structs_test.go.orig ./structs/structs_test.go
--- ./structs/structs_test.go.orig	2019-06-04 15:04:26.968509155 +0000
+++ ./structs/structs_test.go	2019-06-04 15:04:26.968509155 +0000
@@ -19,7 +19,7 @@
 		{
 			name: "normal struct",
 			args: &args{
-				in: struct{
+				in: struct {
 					ID string
 				}{
 					ID: "123",
@@ -32,7 +32,7 @@
 		{
 			name: "allow struct tags",
 			args: &args{
-				in: struct{
+				in: struct {
 					ID string `json:"my_id"`
 				}{
 					ID: "123",

@github-actions
Copy link

github-actions bot commented Jun 4, 2019

golint

gqlclient.go:8:1: comment on exported type Client should be of the form "Client ..." (with optional leading article)
structs/structs.go:10:1: exported function Unpack should have comment or be unexported
structs/structs.go:26:1: exported function StructToMap should have comment or be unexported

@steebchen steebchen merged commit da2e3f8 into master Jun 4, 2019
@steebchen steebchen deleted the refactor/gqlclient branch June 4, 2019 15:51
@steebchen steebchen added the kind/enhancement New feature or request label Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant