Fix off by one height index in createTgaBuffer #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaxxel
force-pushed
the
fix-off-by-1-height-index
branch
from
9e6b2e3
to
2001c5e
Compare
The image generated by createTgaBuffer was shifted one pixel towards the top and a transparent line was visible at the bottom.
alaxxel
force-pushed
the
fix-off-by-1-height-index
branch
from
2001c5e
to
766bb02
Compare
|
That's a very stupid mistake, thanks for your pull request! |
|
You're welcome, and thanks for releasing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image generated by createTgaBuffer was shifted one pixel towards the
top and a transparent line was visible at the bottom.
Thank you for this great library!