Move runtime gem dependencies from Gemfile back to gemspec file #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This undoes partially PR steelThread@5cec1c4 The reason is that dependencies declared in the Gemfile but not in the gemspec are not visible when including this gem in an app bundle. This means that app startup can fail because a necessary gem for redmon (e.g. haml) is not present in the bundle. The fix is to declare all necessary runtime dependencies in the gemspec, so that any bundle that includes this gem will include its dependencies as well. Fixes steelThread#86
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This undoes partially PR 5cec1c4
The reason is that dependencies declared in the Gemfile but not in the gemspec are not visible when including this gem in an app bundle. This means that app startup can fail because a necessary gem for redmon (e.g. haml) is not present in the bundle. The fix is to declare all necessary runtime dependencies in the gemspec, so that any bundle that includes this gem will include its dependencies as well.
Fixes #86