Use updated way to connect with Redis #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should probably do this a little differently. Do you know when this change was made? Should close out v0.0 with #connect and move to v0.1 with some versioning on the dep gems. |
|
@steelThread The commit itself redis/redis-rb@895cc32 was made 2 years ago, but only went out on v4.0 about two weeks ago: https://github.com/redis/redis-rb/releases/tag/v4.0.0 I agree, updating the version and pinning the deps is the way to go. Want me to close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the commit redis/redis-rb@895cc32 the Redis library deprecated the
Redis.connectthat this application depends on. Because the Redis dependency doesn't have the version pinned, using the latest version of this application is broken out of the box.This merge request helps fix that.