Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Atom with Linter 1.11.4 pre-installed and it fails to activate #1163

Closed
fusion809 opened this issue May 30, 2016 · 3 comments · Fixed by #1164
Closed

Building Atom with Linter 1.11.4 pre-installed and it fails to activate #1163

fusion809 opened this issue May 30, 2016 · 3 comments · Fixed by #1164

Comments

@fusion809
Copy link
Contributor

Hi,

I built Atom with this package pre-installed (by editing Atom's package.json, to include Linter 1.11.4 as a bundled package), now whenever I start Atom I get this error report:

Atom Version: 1.7.4
System: "Arch Linux"
Thrown From: linter package, v1.11.4

Stack Trace

Failed to activate the linter package

At Cannot find module './linter.coffee'

Error: Cannot find module './linter.coffee'
    at Module._resolveFilename (module.js:338:15)
    at Function.Module._resolveFilename (/usr/share/atom/resources/app.asar/src/module-cache.js:383:52)
    at Function.Module._load (module.js:289:25)
    at Module.require (module.js:366:17)
    at require (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:50:27)
    at Object.module.exports.activate (/usr/share/atom/resources/app.asar/node_modules/linter/lib/main.js:154:20)
    at Package.module.exports.Package.activateNow (/usr/share/atom/resources/app.asar/src/package.js:183:20)
    at /usr/share/atom/resources/app.asar/src/package.js:156:32
    at Package.module.exports.Package.measure (/usr/share/atom/resources/app.asar/src/package.js:92:15)
    at /usr/share/atom/resources/app.asar/src/package.js:149:26
    at Package.module.exports.Package.activate (/usr/share/atom/resources/app.asar/src/package.js:146:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/usr/share/atom/resources/app.asar/src/package-manager.js:538:21)
    at /usr/share/atom/resources/app.asar/src/package-manager.js:519:29
    at Config.module.exports.Config.transactAsync (/usr/share/atom/resources/app.asar/src/config.js:337:18)
    at PackageManager.module.exports.PackageManager.activatePackages (/usr/share/atom/resources/app.asar/src/package-manager.js:514:19)
    at PackageManager.module.exports.PackageManager.activate (/usr/share/atom/resources/app.asar/src/package-manager.js:497:46)
    at /usr/share/atom/resources/app.asar/src/atom-environment.js:754:28

Commands

Config

{
  "core": {
    "customFileTypes": {
      "source.ini": [
        ".buckconfig",
        ".flowconfig"
      ],
      "source.json": [
        ".arcconfig",
        "BUCK.autodeps"
      ],
      "source.lisp": [
        ".emacs",
        ".spacemacs"
      ],
      "source.python": [
        "BUCK"
      ],
      "text.html.basic": [
        "ejs",
        "htm",
        "html",
        "kit",
        "shtml",
        "tmpl",
        "tpl",
        "xhtml"
      ]
    },
    "disabledPackages": [
      "language-markdown",
      "atom-beautify",
      "atomic-chrome",
      "build",
      "Hydrogen",
      "git-plus",
      "language-asciidoc"
    ],
    "projectHome": "/home/fusion809/GitHub/mine",
    "themes": [
      "fusion-ui",
      "dark-bint-syntax"
    ]
  },
  "linter": {}
}

Installed Packages

# User
No installed packages

# Dev
No dev packages
@fusion809 fusion809 changed the title Building Atom with this package pre-installed; failed to activate Linter 1.11.4 Building Atom with Linter 1.11.4 pre-installed and it fails to activate May 30, 2016
@steelbrain
Copy link
Owner

As far as I can see, linter has been bundled but hasn't been compiled coffee -> js, I am not much experienced in this area so I am afraid I won't be able to help you much

@fusion809
Copy link
Contributor Author

fusion809 commented May 30, 2016

@steelbrain I've noticed that other packages with CoffeeScript components have coffee-script in the devDependencies section of their package.json. I wonder if maybe this package needs this in order for my build to work.

@fusion809
Copy link
Contributor Author

Aha, I was right! Adding coffee-script to the devDependencies fixes this problem. I'm gonna start a new pull request for this.

steelbrain added a commit that referenced this issue May 31, 2016
Adding coffee-script devDep to package.json, along with readme: field, hence fixing #1163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants