Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm windows support #5

Closed
steelbrain opened this issue Sep 6, 2015 · 3 comments
Closed

Confirm windows support #5

steelbrain opened this issue Sep 6, 2015 · 3 comments
Assignees
@steelbrain
Labels
bug

Comments

@steelbrain
Copy link
Owner

We might or might not have to add .exe to APMPath on windows. I'll try this on a windows PC soon.
@steelbrain
Copy link
Owner Author

Just a simple patch required to make it work on windows.

- if (output.indexOf('✓') === -1) {
+ if (output.indexOf('✓') === -1 && output.indexOf('[32mdone') === -1) {

@steelbrain steelbrain self-assigned this Sep 6, 2015
@steelbrain steelbrain added the bug label Sep 6, 2015
@steelbrain
Copy link
Owner Author

Fixed by #6
Now all we need is a new release

@steelbrain
Copy link
Owner Author

Confirmed as of v2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steelbrain steelbrain

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@steelbrain