-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy load #270
Merged
Merged
Lazy load #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any feedback on this? This is ready |
Thank you for working on this, looks good, I'll review/merge this weekend |
By targeting electron 5, package-deps is now even faster. |
@steelbrain Any update on this? This is a small change. I just moved the code to different files, and I used dynamic import in the main file. |
I'll review within the next 24 hours :) |
Applied some touchups in #281 |
Awesome! |
This was referenced Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because many packages depend on package-deps, I think this optimization will benefit the whole Atom ecosystem.
This is tested and works as expected. It reduces the load time of a test package by 12ms (using
![2020-05-05 22_33_27-Timecop — C__Users_yahyaaba_Documents_GitHub_JavaScript_atom-ide-community_atom-](https://user-images.githubusercontent.com/16418197/81136292-c7152a80-8f20-11ea-86f6-5efce7e034f3.jpg)
![2020-05-05 22_37_29-Timecop — C__Users_yahyaaba_Documents_GitHub_JavaScript_atom-ide-community_atom-](https://user-images.githubusercontent.com/16418197/81136416-23784a00-8f21-11ea-8a6a-3a20255a4946.jpg)
require("atom-package-deps").install
):before
after
Small other changes:
compile
in scripts todebug