Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No update on changing linked modules outside project root #180

Closed
natew opened this issue Jul 19, 2018 · 5 comments
Closed

No update on changing linked modules outside project root #180

natew opened this issue Jul 19, 2018 · 5 comments

Comments

@natew
Copy link

natew commented Jul 19, 2018

Using a mono-repo and editing some sub-deps it seems not to trigger pundle updates until i restart the server itself.

I looked into preset-default and --help for some config options and didn't see anything clear for this specific case.

@steelbrain
Copy link
Owner

Pundle by default only watches the root directory. This will be changed to eventually all the required files regardless of where they are but It's gonna take time

@steelbrain steelbrain changed the title No update on changing node_modules No update on changing linked modules outside project root Jul 20, 2018
@steelbrain
Copy link
Owner

While watcher support for individual files is some time away, I've set followSymlinks to true in chokidar (nsfw watcher doesn't support it). So when f9b5489 is released, you should be able to do --watch.adapter chokidar to fix watcher support for linked modules outside root directory

@steelbrain
Copy link
Owner

steelbrain commented Jul 23, 2018

Update! The change was released. You can append --watch.adapter chokidar to your dev command to fix watching linked directories

@natew
Copy link
Author

natew commented Aug 24, 2018

Guessing this is no longer issue because chokidar was removed?

@steelbrain
Copy link
Owner

nsfw was removed and chokidar was made default, so yes, this shouldn't be an issue in latest release

@natew natew closed this as completed Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants