Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prereq install fails on latest stable node version #2436

Closed
sneak opened this issue Jan 31, 2018 · 1 comment
Closed

prereq install fails on latest stable node version #2436

sneak opened this issue Jan 31, 2018 · 1 comment
Assignees

Comments

@sneak
Copy link
Contributor

sneak commented Jan 31, 2018

I'm a developer/entrepreneur. I use steemit all the time and want to add a feature to condenser. I make a blog post and it gets widespread support. I make an issue in the issue tracker proposing it and TPTB say it'd get merged if I wrote it.

I sit down to my brand new freshly installed Macintosh with High Sierra and install Xcode and homebrew. I brew install node and npm install -g yarn to bring up a dev environment. I clone condenser and check out master with the plan to run the tests to verify my dev environment baseline is set up correctly. I get an error because it can't install on the latest stable version of node that homebrew installs.

✔ ~/tmp/condenser [master|…1] 
23:15 $ yarn install
yarn install v1.3.2
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
error @steemit/rpc-auth@1.1.0: The engine "node" is incompatible with this module. Expected version "^8".
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
✘-1 ~/tmp/condenser [master|…1] 
23:18 $ node -v
v9.4.0
✔ ~/tmp/condenser [master|…1] 
23:18 $ 

I know node 8 is LTS, but that doesn't actually matter at all if you read that user story.

@sneak
Copy link
Contributor Author

sneak commented Jan 31, 2018

I believe this just requires an rpc-auth bamp (plus associated runtime-major-version-number-change QA and testing) because steemit/rpc-auth#16 is already done and merged.

@bnchdrff bnchdrff self-assigned this Feb 5, 2018
bnchdrff added a commit that referenced this issue Feb 9, 2018
fixes #1637

update some dependencies

remove medium-editor-insert-plugin

fixes #2127

fix case in property

fixes #2475

remove purest, add blueimp-file-upload

blueimp-file-upload was an implicit dependency from the medium-editor-insert-plugin
but we explicitly require it in our webpack config

update co-body

update deps (fixes #2436) and remove fsevents (unused)

update koa-static-cache

Co-authored-by: Originate <originated@users.noreply.github.com>
bnchdrff added a commit that referenced this issue Feb 14, 2018
fixes #1637

update some dependencies

remove medium-editor-insert-plugin

fixes #2127

fix case in property

fixes #2475

remove purest, add blueimp-file-upload

blueimp-file-upload was an implicit dependency from the medium-editor-insert-plugin
but we explicitly require it in our webpack config

update co-body

update deps (fixes #2436) and remove fsevents (unused)

update koa-static-cache

Co-authored-by: Originate <originated@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants