New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
446 linkify username in comment #1686
Conversation
There is a history bug. Steps to reproduce:
expected: return to post page actual: nothing happens (this is not in relation to the issue i filed with middle-clicking to make a new tab; just on the single, original tab.) |
…emit/condenser into 446-linkify-username-in-root-comment
@sneak there was a bug with addEventListener and removeEventListener not always being present. Added checks; that's fixed most of the "back" navigation problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, working well. The only potential UI issue I see is that the author name is now underlined on hover -- I don't believe condenser uses any underlined links, hover or not.
@roadscape - there's variation in links. Some are underlined, some are not. I've added a bit of styling to remove the underline for these. |
#446
Author name is now always a link. Default browser behavior on the links is canceled unless or keys are pressed while clicking. A toggle event for the popup is fired if those keys are not pressed.