Add "#" to "Steemit" when using Twitter share #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a post is shared on twitter through the twitter share button, the title to the post is included and "Steemit" is appended, adding a hashtag will improve analytics and social media performance. This change is intended to add a hashtag so that every time a steemit post is shared on twitter it features "#steemit."
|
Looks good @andrarchy - has this been tested? It looks like you created the branch on a fork in your own user account instead of a branch in the steemit repo, which means you can't do a test deploy to dev... |
valzav
approved these changes
Sep 15, 2017
|
@andrarchy, I agree with Sneak - it's more practical to use local branch instead of fork to submit PR, I'm merging it for now without deploying to dev because this change only affects one string, if it's more changes we wouldn't be able to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a post is shared on twitter through the twitter share button, the title to the post is included and "Steemit" is appended, adding a hashtag will improve analytics and social media performance. This change is intended to add a hashtag so that every time a steemit post is shared on twitter it features "#steemit."