-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add component for selecting rpc node #3887
Conversation
HappyBerrysBoy
commented
Apr 20, 2023
- Add Component in the setting page
- Add RPC Node List in the default.json
- Change api endpoint for loading posting/comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More explanation in my steemit comment. Further code suggestions should add as a commit.
src/app/Main.js
Outdated
|
||
const steemSelectedRpc = localStorage.getItem('steemSelectedRpc'); | ||
|
||
if (steemSelectedRpc) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overwrites steemSelectedRpc
with the config value even if a valid value was just loaded.
if (steemSelectedRpc) { | |
if (!steemSelectedRpc) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked your comment.
I fixed bug and updated your comments.
Thanks for your kindly review.
- Main.js Bug Fix(steemSelectedRpc => !steemSelectedRpc) - Set state(rpcNode, rpcError) - Show rpcError under component when invalid rpc url format