-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Market bug fixes #728
Market bug fixes #728
Conversation
@roadscape could you please review? |
For the mysql, that's beyond me tbh, I just found those instructions on stackoverflow as other users have reported similar issues. I think that the mysql root user should be independent from your OS root user, but for some reason that's not the case in Ubuntu 16.x. About the percentDiff method, it must've gotten bugged at one point because it was always returning 0 since the two amounts input were always the same. The greying out still happens, but now whenever the price differs by 15% or more from the market prices. The 15% is completely open to tuning, it's just a number that seemed ok to me. |
It would probably return 0 for most values which are not in the sub-10 satoshi ranges. It does seem better to repurpose it for this case; 15% seems reasonable. I'll give it a final test and merge today. |
Great, thanks for the mysql fix. That is tricky. In the future we should probably use a bound component .. or correct me if I'm missing something. Thanks.. |
Yes the value change via refs was just to stay in line with how it was already being done. |
Also includes an update to the README for Ubuntu 16.x