Also update global account state on MarketSaga get_accounts, fixes #437 #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roadscape
reviewed
Dec 1, 2016
| if(account) { | ||
| account = fromJS(account) | ||
| yield put(MarketReducer.actions.receiveAccount({ account })) | ||
| yield put(g.actions.receiveAccount({ account })) |
There was a problem hiding this comment.
Is yield put(g.actions.receiveAccount({ account })) required for the witness page fix? Is there possibly a more relevant place to put this line, just in case fetchOpenOrders is no longer called on every page load in the future?
There was a problem hiding this comment.
Hm you're right actually. The issue is that fetchOpenOrders is the only place that calls get_accounts with your account when you log in. If we can put that in loginWatch in UserSaga for example that would be better, or we can add a special case in fetchState.
roadscape
approved these changes
Dec 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the state.market.account object immutable as well which is why Market.jsx needed an update.