Remove account from market state, use SagaShared getAccount to fetch … #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roadscape
approved these changes
Dec 5, 2016
roadscape
approved these changes
Dec 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…accounts #437
In my previous commit for #437 I added the global reducer to MarketSaga but @roadscape mentioned this was not really desirable so I decided to refactor it again. I noticed the market state was keeping a duplicate of the account object that could just as easily be pulled from state.global.accounts so Market.jsx now uses that account object instead.
Also, SagaShared has a getAccount method but AuthSaga and MarketSaga was duplicating that method so I replaced them with the shared method.