Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

condenser get_state accounts compat #118

Closed
roadscape opened this issue Jun 5, 2018 · 3 comments
Closed

condenser get_state accounts compat #118

roadscape opened this issue Jun 5, 2018 · 3 comments

Comments

@roadscape
Copy link
Contributor

Condenser relies on quite a few account fields, mostly for the logged in user. In other cases it needs only very basic details. However, the logged-in account plus all others which are needed for 'soft references' are kept in the same structure.

Since hive does not serve full account data (e.g. block-accurate keys/permissions as needed for login and transfers), we need to find a solution which will serve condenser without changing core hive requirements.

Potential solution:

  • deliver all hive 'lite' accounts in a separate key
    • have condenser read there first for soft refs
    • benefit: lightweight hive-native responses, serves 95% of cases
  • for the rest, ensure condenser always accesses accounts through a central method
    • e.g. using the existing getAccount method
    • which already has ability to re-fetch accounts not in accounts key
@roadscape
Copy link
Contributor Author

action plan cc @bnchdrff @gl2748

stage 1

  • do not serve any account data from hivemind
  • verify that condenser is able to recover by requesting accounts as needed (e.g. ensure critical calls all use UserSaga/getAccount which knows to fetch if missing)

stage 2

  • have hive serve lightweight account data under a different key
  • light accounts are used (exclusively?) by condenser's discussion thread view. have condenser check for light account data w/ fallback to legacy.
    • will save us excess calls for data which can be served natively by hive.

@roadscape
Copy link
Contributor Author

Issue w/ account tabs: the feed/blog/comments/replies tabs require account key to be present. For now testing omitting accounts on discussion threads only.

@roadscape
Copy link
Contributor Author

This is now a condenser-focused issue: steemit/condenser#2899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants