Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block streamer should check max_head_age in addition to max_gap #123

Closed
roadscape opened this issue Jun 11, 2018 · 0 comments · Fixed by #137
Closed

block streamer should check max_head_age in addition to max_gap #123

roadscape opened this issue Jun 11, 2018 · 0 comments · Fixed by #137

Comments

@roadscape
Copy link
Contributor

There was a case where a node was forked for several hours, stuck on the same block. When the endpoint recovered, hive-sync continued following blocks at a 3s interval but way behind head. Checking head block time would allow us to easily detect this condition. It should be treated the same way as the max-gap check; i.e. exit listen routine and return to fast-sync.

@roadscape roadscape added the bug label Jun 11, 2018
@roadscape roadscape added this to the 1.0 milestone Jun 11, 2018
@bnchdrff bnchdrff added the 1 label Jun 12, 2018
@roadscape roadscape self-assigned this Jun 12, 2018
roadscape added a commit that referenced this issue Jun 29, 2018
@roadscape roadscape mentioned this issue Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants