-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect price calculation in estimateAccountValue #418
Comments
We should add 8 digits like Bitcoin, Monero and everything else |
there is an issue linked with the post reward as well! |
Less than $ 0.2 is ignored. |
I've written a post about what I noticed: plus another user got an issue with his SP, here the link: |
I just realized this is the korean translation of my post ;) So less than $0.2 are ignored due to what? Is there a solution? |
Sorry, my mistake $0.2 -> $0.02 |
#418 correct price feed ratio. Version bump 0.7.3
This line fails to divide by the quote part of the feed price ratio and therefore computes an incorrect price when the quote is not 1.000.
https://github.com/steemit/steem-js/blob/master/src/formatter.js#L103
This is the case currently as the consensus logic is adjusting the feed price to maintain the 10% SBD to STEEM market cap limit, resulting in a complex ratio:
"median_sbd_price": { "base": "122615385.381 SBD", "quote": "283814541.914 STEEM" }
. It could also occur if witnesses started reporting the price feed using a quote other than 1.000. For example, this could happen at very low STEEM prices, in order to enable more than three fractional digits.This is now causing incorrect output in many UIs
There are probably similar bugs elsewhere in the library.
The text was updated successfully, but these errors were encountered: