Add & remove a key in key_auth

[bonustrack]

I have some trouble making this working and interested to have your feedback.

I created 2 helpers functions: addKeyAuth and removeKeyAuth for adding and removing a key inside user account key_auths array. It's using the operation account_update to do this change (

steem-js/src/broadcast/helpers.js

Lines 109 to 118 in d81a9a3

	steemBroadcast.accountUpdate(
	activeWif,
	userAccount.name,
	owner,
	active,
	posting,
	userAccount.memo_key,
	userAccount.json_metadata,
	cb
	);

) .

We have already the helpers functions addAccountAuth and removeAccountAuth that working well, but for some reason when i try to add a key instead of an account i got the error "Missing Active Authority". I've verified the private active WIF and account_update operation payload and they are valid.

Any idea what is wrong?

[bonustrack]

Created an issue on steem repo steemit/steem#1272

[roadscape]

From abit in above issue:

Perhaps a serialization issue. Accounts and keys should be sorted correctly. Currently keys are converted to addresses before sorting.

[bonustrack]

Awesome it's finally working with Abit suggestion :)

[yamadapc]

If this fails the callback won't be called, you want to use one of either promises or callbacks all the way

[yamadapc]

Same as above

[yamadapc]

This section is slightly confusing to me, too many variables, but all good

[yamadapc]

Hm, the first argument should always be an Error instance

[sneak]

what if the account has a different threshold?

[bonustrack]

If the account has a weight_threshold of 2 then the newly added key will not be able to broadcast alone if the weight is not set to 2. I can change the default weight to use the same value as weight_threshold.

[sneak]

i would love for these arguments to be named instead of positional

[bonustrack]

@sneak i've changed the arguments to be named instead of positional and now if weight is not specified it take the weight_thresold value as default weight.

[sneak]

awesome. in general i prefer named arguments vs positional for anything that takes more than 1-2 params. using names like signingKey instead of activeWif shows which key is which, too.

it makes it possible to audit calling code for correctness without knowing the api being called into.

[bonustrack]

Yes it make sense, on the rest of the library both solutions (named and positional) are possible example:

steem.broadcast.transferWith(key, { from, to, amount, memo }, cb) // named
steem.broadcast.transfer(key, from, to, amount, memo, cb) // positional

I've renamed activeWif to signingKey also.

[gregory-latinier]

Adding and removing a key work