Added .logger support to .api.setOptions #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sneak
suggested changes
Sep 6, 2017
sneak
approved these changes
Sep 6, 2017
bonustrack
reviewed
Sep 6, 2017
There was a problem hiding this comment.
The intend should be specified here so IDE can adapt:
Line 11 in 2204f6e
Actually most of the library use 2 spaces intend we might want to set the same format on the whole library.
bonustrack
approved these changes
Sep 6, 2017
|
@bonustrack - please merge. I don't have perms for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for an injectable external logger to api. Logger could be a function, or an object with functions for different log levels à la quirky's logger.
Implementing logging within a function is as easy as this.log('level', [logitem1, ....[logitemN]])
Logging can be stopped by calling .setOptions({logging:false})