Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix params get_content_replies #246

Merged
merged 1 commit into from
Sep 20, 2017
Merged

Fix params get_content_replies #246

merged 1 commit into from
Sep 20, 2017

Conversation

bonustrack
Copy link
Contributor

Steem REST API (api.steemjs.com) rely on steem-js file src/api/methods.js to parse parameters. The request https://api.steemjs.com/get_content_replies?author=siol&permlink=test was failing because params were wrong in steem-js mapping

gregory-latinier
gregory-latinier approved these changes Sep 19, 2017
View reviewed changes
Copy link

@gregory-latinier gregory-latinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct match:
https://github.com/steemit/steem/blob/master/libraries/app/database_api.cpp#L1136

@bonustrack
Copy link
Contributor Author

Yes i was relying on this https://github.com/steemit/steem/blob/8cd5f688d75092298bcffaa48a543ed9b01447a6/libraries/app/include/steemit/app/database_api.hpp#L337

@bonustrack bonustrack merged commit b6810e5 into master Sep 20, 2017
@bonustrack bonustrack deleted the fix-get-content-replies branch September 20, 2017 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregory-latinier gregory-latinier gregory-latinier approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bonustrack @gregory-latinier