Fix Error Causing Voting to Fail #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voting using `.vote()` checks if the post is archived, and if it is, it raises the `VotingInvalidOnArchivedPost` error. However, prior to this fix, it checked if the `net_rshares` of the post was 0, which would also fire if the post did not have any votes on it yet. This fix allows posts that aren't archived but have 0 votes to be voted on.
|
+1. |
cyon1c
approved these changes
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voting using
.vote()checks if the post is archived, and if it is, it raises theVotingInvalidOnArchivedPosterror.However, prior to this fix, it checked if the
net_rsharesof the post was 0, which would also fire if the post did not have any votes on it yet. This fix allows posts that aren't archived but have 0 votes to be voted on.