Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiled code is compatible with windows #311

Closed
xiangxn opened this issue Aug 21, 2016 · 4 comments
Closed

Compiled code is compatible with windows #311

xiangxn opened this issue Aug 21, 2016 · 4 comments

Comments

@xiangxn
Copy link

xiangxn commented Aug 21, 2016

Compiled code is compatible with windows Visual Studio 2013:
witness.cpp[409]:
old:void witness_plugin::on_applied_block( const chain::signed_block& b )
new:void witness_plugin::on_applied_block(const steemit::chain::signed_block& b)

market_history_plugin.cpp[24]:
old:flat_set<uint32_t> _tracked_buckets = { 15, 60, 300, 3600, 86400 };
new:flat_set<uint32_t> _tracked_buckets = flat_set<uint32_t>{ 15, 60, 300, 3600, 86400 };

authority.cpp[82]:
old:
for( auto item : account_auths ) FC_ASSERT( is_valid_account_name( item.first ) );
new:
for (auto item : account_auths){ FC_ASSERT(is_valid_account_name(item.first)); }

database.cpp[2013]:
old:if( shares == 0 ) return;
new:if (shares == fc::uint128(0)) return;
The above modification in vs2013 compile "steemd.exe"

@abitmore
Copy link
Contributor

abitmore commented Aug 23, 2016

Thanks. Better submit a pull request.

@theoreticalbts
Copy link
Contributor

Duplicate of #288 -- these issues were reported by @btscube in prehistoric times, and have been merged to develop for a while.

@xiangxn
Copy link
Author

xiangxn commented Aug 28, 2016

merged?
The combined not in master?

@xiangxn
Copy link
Author

xiangxn commented Aug 28, 2016

There is also a small bug: division by zero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants