Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Resteemed on Blog #426

Merged
merged 1 commit into from
Oct 10, 2016
Merged

Show Resteemed on Blog #426

merged 1 commit into from
Oct 10, 2016

Conversation

thebitcoiner
Copy link
Contributor

This will allow users to go to a blog and be able to easily tell which posts are from the author and which were resteemed.

The pattern from the feed was followed.

Here is an example of what it is currently:

image

Here is what it will look like:

image

@roadscape
Copy link
Contributor

This may be better solved by having the backend return first_reblogged_by for user blog feeds, as this would not require any workarounds on the front end

@roadscape
Copy link
Contributor

But if we want to go this route for now, I'd recommend changing

 +        if(account && account != content.get('author')) {
 +          reblogged_by = <div className="PostSummary__reblogged_by">
 +                             <Icon name="reblog" /> Resteemed
 +                         </div>
 +        }
 +

to

          let reblogged_by = content.get('first_reblogged_by')
 +        if(!reblogged_by && account && account != content.get('author')) {
 +            reblogged_by = account // workaround #426
 +        }
          if(reblogged_by) {

to leverage the existing html generation logic

@thebitcoiner
Copy link
Contributor Author

Yes, having a way to get first_reblogged_by from backend would be better and will allow for the next step, showing the Resteemed on another tab.

I agree the workaround makes for cleaner code, but getting feedback from others on chat, most have said they don't want to see the " by author" text, just Resteemed, on the blog.

@thebitcoiner
Copy link
Contributor Author

Further feedback? Can we leave as is?

@valzav valzav merged commit 8edf644 into steemit:develop Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants