New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code analysis warnings #47

Closed

coeing opened this issue Aug 31, 2020 · 3 comments

Assignees

Milestone

Collaborator

coeing commented Aug 31, 2020 •

edited

Right now we have a lot of code analysis warnings popping up during a Maven build:

mvn install

The code analysis report can be found at openhab-addons/bundles/org.openhab.binding.boschshc/target/code-analysis/report.html afterwards.

We have probably all skipped the code analysis during our work, so the warnings piled up. In the future we should run a normal build each time we merge a pull request.

For now we should fix those as soon as possible to avoid code smells.

The text was updated successfully, but these errors were encountered:

coeing assigned GerdZanker, coeing and stefan-kaestle

coeing added this to the 1.0 milestone

coeing added a commit that referenced this issue


          #47 Fixed code analysis warnings

ec5f294

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

Collaborator Author

coeing commented Aug 31, 2020

Fixed some first warnings in my classes, 34 warnings left :)

coeing added a commit that referenced this issue


          #47 Fixed code analysis warnings

e5d9946

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

coeing added a commit that referenced this issue


          #47 Fixed code analysis warnings

66b2d3f

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

coeing added a commit that referenced this issue


          #47 Fix code formatting to remove code analysis warnings

655aee1

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

Collaborator Author

coeing commented Oct 1, 2020 •

edited

Warnings left:

3 TODOs in BoschSHCBridgeHandler.java and BoschSslUtil.java (we should turn those into issues)
AvoidThrowingRawExceptionTypes in BoschSHCHandler.java

coeing added a commit that referenced this issue


          #47 Throw BoschSHCException instead of raw error to avoid code analys…

5beacb3

…is warning

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

coeing added a commit that referenced this issue


          #47 Remove TODO from code and add issue #55 instead

b056236

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

coeing added a commit that referenced this issue


          #47 Pass non-null httpClient to bridge initialization instead of havi…

c19df48

…ng to check for null reference

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

Collaborator Author

coeing commented Oct 18, 2020

Fixed remaining warnings. If new ones should arrive, we should open new issues for each one (or a group of them) to avoid having long open issues :)

coeing closed this as completed

coeing added a commit that referenced this issue


          #47 Fixed code analysis warnings

e1511fc

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

coeing added a commit that referenced this issue


          #47 Fix code formatting to remove code analysis warnings

80f801a

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

coeing added a commit that referenced this issue


          #47 Throw BoschSHCException instead of raw error to avoid code analys…

92bc24d

…is warning

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

coeing added a commit that referenced this issue


          #47 Remove TODO from code and add issue #55 instead

7095a10

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

coeing added a commit that referenced this issue


          #47 Pass non-null httpClient to bridge initialization instead of havi…

d2389b2

…ng to check for null reference

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

coeing added a commit that referenced this issue


          #47 Starting http client before scheduling initial access

575c5b5

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

coeing added a commit that referenced this issue


          #47 Fixed code analysis warnings

935e37b

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

coeing added a commit that referenced this issue


          #47 Fix code formatting to remove code analysis warnings

b3d9186

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

coeing added a commit that referenced this issue


          #47 Throw BoschSHCException instead of raw error to avoid code analys…

03ebbc2

…is warning

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

coeing added a commit that referenced this issue


          #47 Remove TODO from code and add issue #55 instead

5ffbc9a

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

coeing added a commit that referenced this issue


          #47 Pass non-null httpClient to bridge initialization instead of havi…

5fd9f36

…ng to check for null reference

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

coeing added a commit that referenced this issue


          #47 Starting http client before scheduling initial access

8c19b01

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

GerdZanker pushed a commit that referenced this issue


          #47 Fixed code analysis warnings

d7070a3

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

GerdZanker pushed a commit that referenced this issue


          #47 Fix code formatting to remove code analysis warnings

4b3a36a

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

GerdZanker pushed a commit that referenced this issue


          #47 Throw BoschSHCException instead of raw error to avoid code analys…

e32e949

…is warning

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

GerdZanker pushed a commit that referenced this issue


          #47 Remove TODO from code and add issue #55 instead

ff3bcba

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

GerdZanker pushed a commit that referenced this issue


          #47 Pass non-null httpClient to bridge initialization instead of havi…

a2bb798

…ng to check for null reference

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

GerdZanker pushed a commit that referenced this issue


          #47 Starting http client before scheduling initial access

647b889

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>

GerdZanker pushed a commit that referenced this issue


          #47 Fixed code analysis warnings

ca62d36

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>

GerdZanker pushed a commit that referenced this issue


          #47 Fix code formatting to remove code analysis warnings

2a7260b

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>

GerdZanker pushed a commit that referenced this issue


          #47 Throw BoschSHCException instead of raw error to avoid code analys…

43cd25a

…is warning

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>

GerdZanker pushed a commit that referenced this issue


          #47 Remove TODO from code and add issue #55 instead

7ce0ad7

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>

GerdZanker pushed a commit that referenced this issue


          #47 Pass non-null httpClient to bridge initialization instead of havi…

1295cae

…ng to check for null reference

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>

GerdZanker pushed a commit that referenced this issue


          #47 Starting http client before scheduling initial access

af04929

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment