New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/shutter control #2
Feature/shutter control #2
Conversation
...ding.boschshc/src/main/java/org/openhab/binding/boschshc/internal/BoschSHCBridgeHandler.java
Outdated
Show resolved
Hide resolved
Stopping the shutters from moving doesn't seem possible with the current API, so I created an issue for it: BoschSmartHome/bosch-shc-api-docs#34 Maybe I can find a workaround in the meantime. |
Remove unnecessary parts of the request like Gateway ID and put some general logic into separate methods to reuse them in other functions later
Alright, this was a short but very successful coding session :) I handled all the remaining TODOs, so from my side the pull request is ready to merge. But please check if it is okay from your side as well! I am using some general functions that can also be used in other places, but I would like to do the refactoring in a separate branch. Next time I have time I will add some issues for the parts I'd like to change, so we can discuss them if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks @coeing!
This all looks good to me. To suggestions:
- Update the list of supported things in Readme.md
- Find a place to put attributions to everybody who worked on the binding. I realize that my editor put my name in a lot of files that you (and Gerd) have been helping to improve, so maybe just add yourself there? Or remove my name and rely on the git history for that?
Great work! 🎆
Please feel free to click the merge button whenever you are ready :-)
@stefan-kaestle Thanks for the review :) About your points:
If you give me write access to the repository, I'll merge my branch after the addition of the shutter control info to the Readme.md. Otherwise I'll let you know when I did the addition :) |
…ControlHandler if device state couldn't be fetched
Alright, I added the Shutter Control device to the supported device section of the Readme.md and added a null reference check because on initialization the device state doesn't seems to be fetched correctly. Will merge the pull request now! 😱 |
Great work! Thanks Christian! 🎉🎉🎉🎉 |
Support for Bosch Shutter Control in-wall device Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
TODO: