Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

card's description of shared boards invisible with read only permission #1635

Open
4 of 7 tasks
Ornanovitch opened this issue May 25, 2024 · 8 comments
Open
4 of 7 tasks

Comments

@Ornanovitch
Copy link

Ornanovitch commented May 25, 2024

This issue respects the following points:

Describe the bug

  1. As user A, create a board plop and share it with user B, with read-only permission
  2. As user B, sync your boards with the android app, then select the board plop and open a card

Description is invisible (attachments, comments and activity are visible) - the bug is reproducible for all concerned users

mobile desktop
mobile desktop

Expected behavior

Description is visible (as in the web browser app)

Deck Android version

1.24.1

Deck server version

1.13.0

Nextcloud Android version

3.29.0

Nextcloud version

29.0.1

Device

Galaxy A5 2017 (reproduced on multiple devices)

Android Version

11

App Store

  • Google Play Store
  • Google Play Store (Beta channel)
  • F-Droid
  • Huawei App Gallery

Stacktrace

No response

@Ornanovitch
Copy link
Author

I see no error in the app logs. The issue seems similar to this old one : #1401

@stefan-niedermann
Copy link
Owner

While I haven't been able to reproduce this very issue, I noticed some other issues that are related to the description field and the read only permission. I'll dig into this further within the bext few days. Thank you for your report!

@Ornanovitch
Copy link
Author

Hey Stefan, any news on your side? Is there anything we can do to help you to progress on this?

@stefan-niedermann
Copy link
Owner

Not yet, I am currently a bit busy, but I didn't forget you. A Pull Request would of course be welcome, the root cause is probably in this method: https://github.com/stefan-niedermann/nextcloud-deck/blob/master/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/details/CardDetailsFragment.java#L151

@stefan-niedermann
Copy link
Owner

Huh. Actually there might only one line missing in the else block:

registerEditorListener(binding.descriptionViewer);

@Ornanovitch
Copy link
Author

Thanks, no problem of course!

Ok! I'll reed this piece of code and try to see if I feel comfortable with opening a PR (I never tried to play with the dev of a mobile app..!), if you can't find time soon :)

Best!

stefan-niedermann added a commit that referenced this issue Jun 12, 2024
Refs: #1635 (comment)

Signed-off-by: Stefan Niedermann <info@niedermann.it>
desperateCoder added a commit that referenced this issue Jun 12, 2024
@desperateCoder
Copy link
Collaborator

Hey, I don't really have the time to set up a proper test environment, but I had enough time to add the line.

Here's a DEV build of the app with the above change: APK ԅ(≖‿≖ԅ)

You can install the APK right beside your version from F-Droid, you'll end up with an additional deck app with the label "DEV" on the icon. Just connect it to your account, let it sync and then please check if the issue is resolved for you.

Looking forward to your feedback! 😊

@Ornanovitch
Copy link
Author

Hi, thanks for those first attempts!

I tried both of your builds, the one from the Stefan's PR and the one from your branch desperateCoder, and sadly both of these apparently do not solve the issue. Worse, the title disappeared too 😅 But maybe it's a clue?

signal-2024-06-12-181805

Note that we don't use the tags, neither the assign, nor the due date, so I don't know for those elements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants