-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle push notifications #208
Comments
The deck app requires the files app to be installed because it only allows login via Single-Sign-On. |
A solution i thought about was: The deck app doesn't handle notifications at all, but registers a URI handler. The files app could check whether or not a handler is registered and redirects the notification-click-action to the deck app....? |
does the deck app even really need push notifications? I mean afaik it's just reminders which are time based... a calender app doesn't need push either for it's notifications generated on data which is synchronized and stored locally... |
@violoncelloCH has a good point there... What else could be a use case for push notifications? |
Comments. It's the single most important aspect of a connected Kanban system. Comments provide clarity and iteration to the original card; when someone posts a comment it is often either a question seeking better understanding or an answer providing it. If you're using Deck as a collaborative project management system, then seeing that a comment has been made is quite important. |
Use cases from my POV:
|
@tobiasKaminsky can you please have a look at this comment and tell me whether this is technically possible and if this is something you would consider to implement at your end? (of course i would be happy to help you at a shared PR) |
Problem is that each 3rd-party app (via SSO) needs an independent app token and currently we cannot create a new app-token from an app-token. Would this be good? (I do not want to have any logic in Files, beside SSO redirecting everything) |
My idea has nothing to do with SSO - It's just about Android stuff. The files app already handles push notifications very well and displays an Android notification when something happens. Clicking on this android notification currently opens the web interface of Nextcloud. My idea is that the files app checks whether or not there is a handler for a special kind of notification, and then starts the Deck android app (if installed) and falls back to opening the webinterface (if not installed), like it is today. The pro would be that no 3rd-party app would have to deal with Android nor Nextcloud push stuff (it's a pain in the ass and i am happy you already got it working so good). |
Might be working. |
Yep, that's where @desperateCoder comes into the game. The files app receives a notification with those fields: https://github.com/nextcloud/android/blob/01b1e719ffdf0546acf54d2e450aca81edee59be/src/main/java/com/owncloud/android/datamodel/DecryptedPushMessage.java#L32-L39 If the field At this point we are in the The documentation of the push notification data says about the
So, at this point we will call the correspondent EditThanks to my gf we now have the architectural graphic in *nice* 😉 |
Yep, no problem at all. Sounds good, as long as the ocs service is implemented and allows me to get the data. The important point is: I need to know for which account, since we could have multiple accounts with conflicting remote-IDs of boards, stacks and cards. |
Yep, this is technically no problem, i already told @tobiasKaminsky that he needs to pass the account. I guess we will get the account like |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Added dummy activity Signed-off-by: Stefan Niedermann <info@niedermann.it>
Remove parentActivityName from PushNotificationActivity Signed-off-by: Stefan Niedermann <info@niedermann.it>
Add intent-filter Signed-off-by: Stefan Niedermann <info@niedermann.it>
Added dummy activity Signed-off-by: Stefan Niedermann <info@niedermann.it>
Remove parentActivityName from PushNotificationActivity Signed-off-by: Stefan Niedermann <info@niedermann.it>
Add intent-filter Signed-off-by: Stefan Niedermann <info@niedermann.it>
Added dummy activity Signed-off-by: Stefan Niedermann <info@niedermann.it>
Remove parentActivityName from PushNotificationActivity Signed-off-by: Stefan Niedermann <info@niedermann.it>
Add intent-filter Signed-off-by: Stefan Niedermann <info@niedermann.it>
Hi there,
this is just a general issue to discuss whether this all makes sense.
For the talk mobile apps we added the following behaviour:
This would allow users that only have the deck app installed, to be notified about card deadlines, etc.
I could look into the necessary changes in the notifications app. From the mobile apps it would require the following things:
/^Mozilla\/5\.0 \(Android\) Nextcloud\-Deck v.*$/
cc @juliushaertl
The text was updated successfully, but these errors were encountered: