New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a trashbin #238

Open
gardiol opened this Issue Aug 18, 2017 · 21 comments

Comments

Projects
None yet
7 participants
@gardiol

gardiol commented Aug 18, 2017

Accidental delete by swipe is annoying. Yes it can be restored, but only from nextcloud file web app, and not from note app.

Please add the option to confirm swipe-delete

This is specially needed by limited mobility or disabled people.

@schaarsc

This comment has been minimized.

Contributor

schaarsc commented Sep 10, 2017

I suggest to rename this issue into "confirm delete" because delete from menu is also missing a confirmation.

Suggestion:

  • create "confirm delete" dialog with "don't show this dialog again" option
  • add dialog to swipe-to-delete and menu-delete
  • add confirm-delete option to preferences (this is optional, but without the don't-show-again option cannot be changed)
@stefan-niedermann

This comment has been minimized.

Owner

stefan-niedermann commented Sep 10, 2017

Well, i like and follow the opinion of @jancborchardt here: Undo is better than confirmation, because users are trained to simply "click away" every pop up.

So i think showing this dialog is wrong. We should better enhance swipe2delete to be less sensitive. Maybe displaying the Undo-action longer would be another point.

When we have a sidebar we could ask for extending the API to get trashbin-information so we can display a own trashbin where notes can be restored from.

@schaarsc

This comment has been minimized.

Contributor

schaarsc commented Sep 10, 2017

for me proper trashbin/undo is an acceptable alternative to confirmation dialog. toast are (depending on the situation) either shown too long or too short.

@gardiol

This comment has been minimized.

gardiol commented Sep 11, 2017

While in my opinion a "confirm dialog" is the only accessible solution, despite all the rage about material design and this (insert your adjective here) fashion... I understand that i cannot row against the masses. Nor i agree with the "let's dumb down UI because people clicks like crazy" idea... it's a make them all dumber instead of having them grow up approach which i find very damaging in the long run.

But i am not here to discuss or impose my views! so, indeed making the delay longer for the toast would help... while you implement a proper trashbin, which would be the actual solution in this case.

Or, what about a "confirmation" which is not a dialog but a button which is revealed after swiping? I am thinking at the notifications in Android 6+, where if you swipe on the persistent ones you reveal a button to access per-app notification settings. This would keep the swipe-to-delete and ensure no accidental deletions without an additional dialog? You could even remove the toast altogether!

@korelstar

This comment has been minimized.

Collaborator

korelstar commented Sep 11, 2017

I like the idea of an integrated trash bin. Is there an API for that in nextcloud/server (REST or PHP?)

@stefan-niedermann

This comment has been minimized.

Owner

stefan-niedermann commented Sep 11, 2017

yes i think there is a REST API, but it would list all deleted files, so the notes server app would have to provide an API that filters the entries for only deleted notes (i think this should be possible, detect if the deleted resource folder is the notes folder)

@jancborchardt

This comment has been minimized.

Contributor

jancborchardt commented Sep 12, 2017

Confirmation dialogs are simply bad design as people tend to click them away anyway. Undo is a much better and error- safe solution. @gardiol I recommend reading this article: https://alistapart.com/article/neveruseawarning

@jancborchardt

This comment has been minimized.

Contributor

jancborchardt commented Sep 12, 2017

And undo would still need to be there even with a trashbin. Going to the trashbin to recover a note is a workaround and cumbersome.

Also, it’s overengineering regarding the problem we have, which is simple accidental deletion.

@korelstar

This comment has been minimized.

Collaborator

korelstar commented Sep 13, 2017

@jancborchardt
I don't think a tashbin is that bad. The article you've linked indicates a trashbin as a good practice. In my view, a trashbin is an undo function which is accessible for a longer period of time. Hence, it would be a good solution for this app: We use the SnackBar for undo functionality, which is accessible for a very limited time-period, only (Android only provides two durations and we are using the longer one already). With the trashbin, we can extend the time-period in which the user can undo a delete without being annoying to user who really want to delete. That's great, isn't it?

Btw.: if you say, a trashbin is bad, why does Nextcloud have it at all?

@korelstar korelstar changed the title from Confirm delete on swipe to Confirm delete on swipe / introduce a trashbin Sep 13, 2017

@jancborchardt

This comment has been minimized.

Contributor

jancborchardt commented Sep 13, 2017

@korelstar I'm not saying trashbin is bad. ;) I'm saying undo needs to be there first as that resolves the issue of accidental deletion that you notice right away.
Trashbin can also be implemented, but will be way more work than an undo functionality.

@korelstar

This comment has been minimized.

Collaborator

korelstar commented Sep 13, 2017

@jancborchardt
We have an undo function since a long time. So what do you are talking about?

@jancborchardt

This comment has been minimized.

Contributor

jancborchardt commented Sep 13, 2017

@korelstar sorry, misworded: I think the current way is good with undo. Maybe it needs to be adjusted. If you like to implement a trashbin on top sure - but undo should work perfectly anyhow. :)

@gardiol

This comment has been minimized.

gardiol commented Sep 15, 2017

@jancborchardt i well know the article you linked and i agree with the general principle, but THAT consideration does NOT take into account disabled people nor accidental AND unattended actions.

@everybodyelse, the undo in place indeed works, but i has never helped me when i needed it the most. Why? Well, when it happens it's because i am either not looking at the phone (never accidentally unlocked your phone in the pocket or while holding it but not looking?) or i am holding it in a very awkward position (never being using it while in bed holding a kid who is just fallen asleep in your arms?) and reaching for the undo cannot be achieved.

So yes, please, a trashbin would be very nice!

@jancborchardt

This comment has been minimized.

Contributor

jancborchardt commented Sep 15, 2017

Alright, then trashbin it is. :) If it's nicely integrated with the server trashbin that's good.

@stefan-niedermann stefan-niedermann changed the title from Confirm delete on swipe / introduce a trashbin to Introduce a trashbin Sep 17, 2017

@korelstar korelstar added the sync label Mar 10, 2018

@stefan-niedermann

This comment has been minimized.

Owner

stefan-niedermann commented Aug 14, 2018

Okay, to increase the user benefit of this issue i would suggest to implement a quick win:

Introduce a new sidebar entry "Deleted Notes" which is basically only a link that opens the trashbin in the browser. This is not optimal, but many people seem not to be aware of the fact that they can recover deleted notes from there.

This would give them the ability to view and recover deleted notes until a proper trashbin can be implemented in the notes server and android app.

@korelstar

This comment has been minimized.

Collaborator

korelstar commented Aug 14, 2018

Nice quick win. Unfortunately, we can't link to a specific directory in the deleted files. The list will always contain all files -- not only notes.

What do you think, @jancborchardt ?

@stefan-niedermann

This comment has been minimized.

Owner

stefan-niedermann commented Aug 14, 2018

Yeah, that's true, but still: When does a user open the trashbin from within the notes app? If he recently deleted a note (mabye by accident) to restore it. This means, the deleted note should be at the very top of the trashbin list when the user opens this link.

Well, as i said: It's a quick win, a compromise due the lack of time of everyone...

@korelstar

This comment has been minimized.

Collaborator

korelstar commented Aug 14, 2018

Yeah, I'm fine with it.

@jancborchardt

This comment has been minimized.

Contributor

jancborchardt commented Aug 17, 2018

Sounds good to me too, good quick win! :)

@AndyScherzinger

This comment has been minimized.

Contributor

AndyScherzinger commented Sep 3, 2018

Just in case you ever want to implement the trashbin via the API (Nc14+) you can always check out nextcloud/android#2588 and I am sure @tobiasKaminsky can help out with any questions :)

@tobiasKaminsky

This comment has been minimized.

Collaborator

tobiasKaminsky commented Sep 24, 2018

Yes, I can help you. It should be possible to only list the content of /Notes.
Maybe we/you can then also include versioning support? This is also done on android client (nextcloud/android#2685)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment