Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a trashbin #238

Closed
gardiol opened this issue Aug 18, 2017 · 23 comments
Closed

Introduce a trashbin #238

gardiol opened this issue Aug 18, 2017 · 23 comments
Labels

Comments

@gardiol
Copy link

gardiol commented Aug 18, 2017

Accidental delete by swipe is annoying. Yes it can be restored, but only from nextcloud file web app, and not from note app.

Please add the option to confirm swipe-delete

This is specially needed by limited mobility or disabled people.

@schaarsc

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@schaarsc

This comment has been minimized.

@gardiol

This comment has been minimized.

@korelstar
Copy link
Member

I like the idea of an integrated trash bin. Is there an API for that in nextcloud/server (REST or PHP?)

@stefan-niedermann
Copy link
Member

yes i think there is a REST API, but it would list all deleted files, so the notes server app would have to provide an API that filters the entries for only deleted notes (i think this should be possible, detect if the deleted resource folder is the notes folder)

@jancborchardt

This comment has been minimized.

@jancborchardt

This comment has been minimized.

@korelstar

This comment has been minimized.

@korelstar korelstar changed the title Confirm delete on swipe Confirm delete on swipe / introduce a trashbin Sep 13, 2017
@jancborchardt

This comment has been minimized.

@korelstar

This comment has been minimized.

@jancborchardt

This comment has been minimized.

@gardiol

This comment has been minimized.

@jancborchardt

This comment has been minimized.

@stefan-niedermann stefan-niedermann changed the title Confirm delete on swipe / introduce a trashbin Introduce a trashbin Sep 17, 2017
@korelstar korelstar added the sync file syncing label Mar 10, 2018
@stefan-niedermann

This comment has been minimized.

@korelstar

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@korelstar

This comment has been minimized.

@jancborchardt

This comment has been minimized.

@AndyScherzinger
Copy link
Member

Just in case you ever want to implement the trashbin via the API (Nc14+) you can always check out nextcloud/android#2588 and I am sure @tobiasKaminsky can help out with any questions :)

@tobiasKaminsky
Copy link
Member

Yes, I can help you. It should be possible to only list the content of /Notes.
Maybe we/you can then also include versioning support? This is also done on android client (nextcloud/android#2685)

@giorgosspam

This comment has been minimized.

@stefan-niedermann
Copy link
Member

Starting with version 3.4.10 the Notes app will open the trashbin of the native Nextcloud app if supported (this requires Nextcloud 3.17.x or higher). As a fallback we will continue to open the trashbin in the Web UI, for example if the Nextcloud app is too old.

I am aware that this is not quite a "real" trashbin which only show notes, but all deleted files of the user. Implementing and maintaining a complete trashbin feature is currently not on the roadmap though. By far most use cases will be covered by this compromise. Deleted notes can easily be recovered, resusing the existing features which are already present.

The drawback of this solution is, that notes which have been created and then deleted without being synchronized to the server once, can not be recovered. Given that all notes are immediately synchronized as soon as an internet connection is available and that background synchronization is enabled by default since v3.4.2, this is a quite special edge case which we pragmatically accept for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants