add an optimization to transpose() for row / column vector special case

stefan-zobel · Jul 20, 2023 · 0ee5bd8 · 0ee5bd8
1 parent 6edc3fa
commit 0ee5bd8
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/src/main/java/net/jamu/matrix/ComplexMatrixDBase.java b/src/main/java/net/jamu/matrix/ComplexMatrixDBase.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2020, 2021 Stefan Zobel
+ * Copyright 2020, 2023 Stefan Zobel
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -1010,6 +1010,9 @@ public ComplexMatrixD conjugateTranspose() {
      */
     @Override
     public ComplexMatrixD transpose() {
+        if (rows == 1 || cols == 1) {
+            return create(cols, rows, Arrays.copyOf(a, a.length));
+        }
         return trans(create(cols, rows));
     }
 

diff --git a/src/main/java/net/jamu/matrix/ComplexMatrixFBase.java b/src/main/java/net/jamu/matrix/ComplexMatrixFBase.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2020, 2021 Stefan Zobel
+ * Copyright 2020, 2023 Stefan Zobel
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -1009,6 +1009,9 @@ public ComplexMatrixF conjugateTranspose() {
      */
     @Override
     public ComplexMatrixF transpose() {
+        if (rows == 1 || cols == 1) {
+            return create(cols, rows, Arrays.copyOf(a, a.length));
+        }
         return trans(create(cols, rows));
     }
 

diff --git a/src/main/java/net/jamu/matrix/MatrixDBase.java b/src/main/java/net/jamu/matrix/MatrixDBase.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2019, 2021 Stefan Zobel
+ * Copyright 2019, 2023 Stefan Zobel
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -858,6 +858,9 @@ public ComplexMatrixD times(ComplexMatrixD B) {
      */
     @Override
     public MatrixD transpose() {
+        if (rows == 1 || cols == 1) {
+            return create(cols, rows, Arrays.copyOf(a, a.length));
+        }
         return trans(create(cols, rows));
     }
 

diff --git a/src/main/java/net/jamu/matrix/MatrixFBase.java b/src/main/java/net/jamu/matrix/MatrixFBase.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2019, 2021 Stefan Zobel
+ * Copyright 2019, 2023 Stefan Zobel
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -858,6 +858,9 @@ public ComplexMatrixF times(ComplexMatrixF B) {
      */
     @Override
     public MatrixF transpose() {
+        if (rows == 1 || cols == 1) {
+            return create(cols, rows, Arrays.copyOf(a, a.length));
+        }
         return trans(create(cols, rows));
     }