missing BN_div() error check?

[setharnold]

libtpms/src/tpm2/crypto/openssl/Helpers.c

Line 524 in bd42b67

BN_div(Q, Qr, N, P, ctx);

Hello, Coverity has pointed out that that BN_div() is called in InitOpenSSLRSAPrivateKey() without checking the return value for an error.

Thanks

[stefanberger]

Thanks. Interestingly Coverity does not tell me that.

[setharnold]

I'm surprised your Coverity didn't mention it; I'm no expert, but the "Calling foo without checking return value (as is done elsewhere N out of M times)" output feels like it's been around for years.

I'm using cov-analysis-linux64-2021.9.0, slapped onto the side of an Ubuntu package build process; are you using the scan.coverity.com service, or a self-hosted version?

Thanks

[stefanberger]

I'm using cov-analysis-linux64-2021.9.0, slapped onto the side of an Ubuntu package build process; are you using the scan.coverity.com service, or a self-hosted version?

I am using their service and trigger the checks via a push to coverity_scan branch, which triggers Travis to build for Coverity and submitted the build to their service.