Resolve some issue discovered by Coverity in agressive mode #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Update the description of the tpm_io_getlocality() callback function that the TPM 2 code invokes to get the currently active locality. It is expected that the called software is trusted and returns a valid locality number at all times and thus also always return TPM_SUCCESS. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
…rity) Only access the entrysize variable if it was read from the buffer. In case of an error just head towards the exit. Previously, an error would also have lead the function to do no more useful processing and exited it with an error code bug Coverity complains that the entrysize variable would be access while it wasn't initialized. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
…erity) Exit the loop when the variable could not be filled with data from the byte stream. This avoids accessing the variable 'element' in case it wasn't initialized. The old could would have accessed the possibly uninitialized variable but exited the loop immediately after. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Pull Request Test Coverage Report for Build 2566
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves some TPM 2 code issue discovered by Coverity in agressive mode.