-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add full proto name to generated structs #25
feat: add full proto name to generated structs #25
Conversation
Seems ok, I'm gonna need to test it a bit more to be fully happy with it |
Ok, this is currently a breaking change (even if it doesn't seem like one). Most users have |
Also, our personal use of grpc-build makes use of the I'll think about this more to hopefully find a solution |
Currently this is still a breaking change (going from I tried just implementing all of them in impl google::protobuf::Empty {
fn ... {}
} which doesn't work (prost by default won't build those in). |
Big refactoring of how to use grpc-build. There's now a builder pattern to set up the tonic/prost configuration, and the building is more manual compared to relying only on tonic as we did before
Also:
NamedMessage
e.g: