eprint protoc args & stderr #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+88
to
+91
| eprintln!( | ||
| "---protoc stderr---\n{}\n------", | ||
| String::from_utf8_lossy(&out.stderr).trim() | ||
| ); |
There was a problem hiding this comment.
Shall we also output stdout? Just in case
There was a problem hiding this comment.
I did initially but it doesn't seem to use it, so removed for simplicity.
There was a problem hiding this comment.
I can add it if you like?
There was a problem hiding this comment.
Ah ok, I think it's fine then
conradludgate
previously approved these changes
Aug 31, 2022
|
Not sure why CI isn't running, can you push an empty commit to nudge it? |
alexheretic
force-pushed
the
eprint-protoc
branch
from
bc8664a
to
7b91a6c
Compare
conradludgate
approved these changes
Sep 1, 2022
|
I don't have admin to fix the required CI checks for the branch protection 😭 |
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protoc can exit
0but not actually work. This PR prints protoc args & stderr output so that this will appear if the build fails.