Apply ECS fixes

stefandoorn · Jan 21, 2019 · 93da8e2 · 93da8e2
1 parent c921422
commit 93da8e2
Show file tree

Hide file tree

Showing 62 changed files with 243 additions and 638 deletions.
diff --git a/src/Builder/BuilderInterface.php b/src/Builder/BuilderInterface.php
@@ -1,16 +1,12 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 namespace SitemapPlugin\Builder;
 
 use SitemapPlugin\Provider\UrlProviderInterface;
 
-/**
- * @author Stefan Doorn <stefan@efectos.nl>
- */
 interface BuilderInterface
 {
-    /**
-     * @param UrlProviderInterface $provider
-     */
     public function addProvider(UrlProviderInterface $provider): void;
-}
+}
diff --git a/src/Builder/SitemapBuilder.php b/src/Builder/SitemapBuilder.php
@@ -1,30 +1,21 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 namespace SitemapPlugin\Builder;
 
 use SitemapPlugin\Factory\SitemapFactoryInterface;
 use SitemapPlugin\Model\SitemapInterface;
 use SitemapPlugin\Provider\UrlProviderInterface;
 
-/**
- * @author Arkadiusz Krakowiak <arkadiusz.krakowiak@lakion.com>
- * @author Stefan Doorn <stefan@efectos.nl>
- */
 final class SitemapBuilder implements SitemapBuilderInterface
 {
-    /**
-     * @var SitemapFactoryInterface
-     */
+    /** @var SitemapFactoryInterface */
     private $sitemapFactory;
 
-    /**
-     * @var array
-     */
+    /** @var array */
     private $providers = [];
 
-    /**
-     * @param SitemapFactoryInterface $sitemapFactory
-     */
     public function __construct(SitemapFactoryInterface $sitemapFactory)
     {
         $this->sitemapFactory = $sitemapFactory;
@@ -63,17 +54,13 @@ public function build(array $filter = []): SitemapInterface
         return $sitemap;
     }
 
-    /**
-     * @param array $filter
-     * @return array
-     */
     private function filter(array $filter): array
     {
         if (empty($filter)) {
             return $this->providers;
         }
 
-        return array_filter($this->providers, function(UrlProviderInterface $provider) use ($filter) {
+        return array_filter($this->providers, function (UrlProviderInterface $provider) use ($filter) {
             return in_array($provider->getName(), $filter);
         });
     }

diff --git a/src/Builder/SitemapBuilderInterface.php b/src/Builder/SitemapBuilderInterface.php
@@ -1,18 +1,13 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 namespace SitemapPlugin\Builder;
 
 use SitemapPlugin\Model\SitemapInterface;
 
-/**
- * @author Arkadiusz Krakowiak <arkadiusz.krakowiak@lakion.com>
- * @author Stefan Doorn <stefan@efectos.nl>
- */
 interface SitemapBuilderInterface extends BuilderInterface
 {
-    /**
-     * @return SitemapInterface
-     */
     public function build(array $filter = []): SitemapInterface;
 
     /**

diff --git a/src/Builder/SitemapIndexBuilder.php b/src/Builder/SitemapIndexBuilder.php
@@ -1,4 +1,6 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 namespace SitemapPlugin\Builder;
 
@@ -7,29 +9,17 @@
 use SitemapPlugin\Provider\IndexUrlProviderInterface;
 use SitemapPlugin\Provider\UrlProviderInterface;
 
-/**
- * @author Stefan Doorn <stefan@efectos.nl>
- */
 final class SitemapIndexBuilder implements SitemapIndexBuilderInterface
 {
-    /**
-     * @var SitemapIndexFactoryInterface
-     */
+    /** @var SitemapIndexFactoryInterface */
     private $sitemapIndexFactory;
 
-    /**
-     * @var array
-     */
+    /** @var array */
     private $providers = [];
 
-    /**
-     * @var array
-     */
+    /** @var array */
     private $indexProviders = [];
 
-    /**
-     * @param SitemapIndexFactoryInterface $sitemapIndexFactory
-     */
     public function __construct(SitemapIndexFactoryInterface $sitemapIndexFactory)
     {
         $this->sitemapIndexFactory = $sitemapIndexFactory;

diff --git a/src/Builder/SitemapIndexBuilderInterface.php b/src/Builder/SitemapIndexBuilderInterface.php
@@ -1,22 +1,15 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 namespace SitemapPlugin\Builder;
 
 use SitemapPlugin\Model\SitemapInterface;
 use SitemapPlugin\Provider\IndexUrlProviderInterface;
 
-/**
- * @author Stefan Doorn <stefan@efectos.nl>
- */
 interface SitemapIndexBuilderInterface extends BuilderInterface
 {
-    /**
-     * @param IndexUrlProviderInterface $provider
-     */
     public function addIndexProvider(IndexUrlProviderInterface $provider): void;
 
-    /**
-     * @return SitemapInterface
-     */
     public function build(): SitemapInterface;
 }
diff --git a/src/Controller/AbstractController.php b/src/Controller/AbstractController.php
@@ -1,26 +1,18 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 namespace SitemapPlugin\Controller;
 
 use SitemapPlugin\Model\SitemapInterface;
 use SitemapPlugin\Renderer\SitemapRendererInterface;
 use Symfony\Component\HttpFoundation\Response;
 
-/**
- * @author Arkadiusz Krakowiak <arkadiusz.krakowiak@lakion.com>
- * @author Stefan Doorn <stefan@efectos.nl>
- */
 abstract class AbstractController
 {
-    /**
-     * @var SitemapRendererInterface
-     */
+    /** @var SitemapRendererInterface */
     protected $sitemapRenderer;
 
-    /**
-     * @param SitemapInterface $sitemap
-     * @return Response
-     */
     protected function createResponse(SitemapInterface $sitemap): Response
     {
         $response = new Response($this->sitemapRenderer->render($sitemap));

diff --git a/src/Controller/SitemapController.php b/src/Controller/SitemapController.php
@@ -1,4 +1,6 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 namespace SitemapPlugin\Controller;
 
@@ -7,21 +9,11 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 
-/**
- * @author Arkadiusz Krakowiak <arkadiusz.krakowiak@lakion.com>
- * @author Stefan Doorn <stefan@efectos.nl>
- */
 class SitemapController extends AbstractController
 {
-    /**
-     * @var SitemapBuilderInterface
-     */
+    /** @var SitemapBuilderInterface */
     protected $sitemapBuilder;
 
-    /**
-     * @param SitemapRendererInterface $sitemapRenderer
-     * @param SitemapBuilderInterface $sitemapBuilder
-     */
     public function __construct(
         SitemapRendererInterface $sitemapRenderer,
         SitemapBuilderInterface $sitemapBuilder
@@ -30,9 +22,6 @@ public function __construct(
         $this->sitemapBuilder = $sitemapBuilder;
     }
 
-    /**
-     * @return Response
-     */
     public function showAction(Request $request): Response
     {
         $filter = [];

diff --git a/src/Controller/SitemapIndexController.php b/src/Controller/SitemapIndexController.php
@@ -1,26 +1,18 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 namespace SitemapPlugin\Controller;
 
 use SitemapPlugin\Builder\SitemapIndexBuilderInterface;
 use SitemapPlugin\Renderer\SitemapRendererInterface;
-use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 
-/**
- * @author Stefan Doorn <stefan@efectos.nl>
- */
 class SitemapIndexController extends AbstractController
 {
-    /**
-     * @var SitemapIndexBuilderInterface
-     */
+    /** @var SitemapIndexBuilderInterface */
     protected $sitemapBuilder;
 
-    /**
-     * @param SitemapRendererInterface $sitemapRenderer
-     * @param SitemapIndexBuilderInterface $sitemapIndexBuilder
-     */
     public function __construct(
         SitemapRendererInterface $sitemapRenderer,
         SitemapIndexBuilderInterface $sitemapIndexBuilder
@@ -29,9 +21,6 @@ public function __construct(
         $this->sitemapBuilder = $sitemapIndexBuilder;
     }
 
-    /**
-     * @return Response
-     */
     public function showAction(): Response
     {
         return $this->createResponse($this->sitemapBuilder->build());

diff --git a/src/DependencyInjection/Compiler/SitemapProviderPass.php b/src/DependencyInjection/Compiler/SitemapProviderPass.php
@@ -1,15 +1,13 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 namespace SitemapPlugin\DependencyInjection\Compiler;
 
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Reference;
 
-/**
- * @author Arkadiusz Krakowiak <arkadiusz.krakowiak@lakion.com>
- * @author Stefan Doorn <stefan@efectos.nl>
- */
 final class SitemapProviderPass implements CompilerPassInterface
 {
     /**

diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php
@@ -1,14 +1,13 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 namespace SitemapPlugin\DependencyInjection;
 
 use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
 use Symfony\Component\Config\Definition\ConfigurationInterface;
 
-/**
- * @author Stefan Doorn <stefan@efectos.nl>
- */
 final class Configuration implements ConfigurationInterface
 {
     /**
@@ -24,9 +23,6 @@ public function getConfigTreeBuilder()
         return $treeBuilder;
     }
 
-    /**
-     * @param ArrayNodeDefinition $node
-     */
     private function addSitemapSection(ArrayNodeDefinition $node): void
     {
         $node

diff --git a/src/DependencyInjection/SitemapExtension.php b/src/DependencyInjection/SitemapExtension.php
@@ -1,4 +1,6 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 namespace SitemapPlugin\DependencyInjection;
 
@@ -7,9 +9,6 @@
 use Symfony\Component\DependencyInjection\Extension\Extension;
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 
-/**
- * @author Stefan Doorn <stefan@efectos.nl>
- */
 final class SitemapExtension extends Extension
 {
     /**
@@ -23,7 +22,6 @@ public function load(array $config, ContainerBuilder $container)
         }
         $config = $this->processConfiguration($configuration, $config);
 
-
         $loader = new XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.xml');
 

diff --git a/src/Exception/RouteExistsException.php b/src/Exception/RouteExistsException.php
@@ -1,10 +1,9 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 namespace SitemapPlugin\Exception;
 
-/**
- * @author Stefan Doorn <stefan@efectos.nl>
- */
 class RouteExistsException extends \Exception
 {
     /**

diff --git a/src/Exception/SitemapUrlNotFoundException.php b/src/Exception/SitemapUrlNotFoundException.php
@@ -1,13 +1,11 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 namespace SitemapPlugin\Exception;
 
 use SitemapPlugin\Model\SitemapUrlInterface;
 
-/**
- * @author Arkadiusz Krakowiak <arkadiusz.krakowiak@lakion.com>
- * @author Stefan Doorn <stefan@efectos.nl>
- */
 class SitemapUrlNotFoundException extends \Exception
 {
     /**