Generate sitemaps from CLI #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefandoorn
force-pushed
the
feature/generate-cli-using-providers
branch
from
d10a4eb
to
0f957d5
Compare
stefandoorn
force-pushed
the
feature/generate-cli-using-providers
branch
from
0f957d5
to
c893655
Compare
loevgaard
requested changes
Jul 30, 2019
This was referenced Jul 31, 2019
stefandoorn
force-pushed
the
feature/generate-cli-using-providers
branch
from
e4e2c97
to
582ecfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic implementation to generate the sitemaps (+ index) from CLI. Plenty of improvements needed, e.g.:
And plenty of other improvements.
I would like to merge this one first, so in consecutive pull requests enhancements can be made. Tests pass again, so we are save to develop on top of this. This pull request is already rather big.